-
Notifications
You must be signed in to change notification settings - Fork 1
Add NaMi lookup #17
Add NaMi lookup #17
Conversation
ackxolotl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partially reviewed
|
Some more ideas on this PR:
|
|
Good ideas!
I think that should be discussed in another Issue (or MR) to keep this one as small as possible.
Probably useless if your first idea is implemented :-)
For those reasons, I would let it as-is. |
|
|
On my tests, |
|
Hm, ok 🤷♂️ Then let's keep it as it is (at least for now). |
The creation of a participant is now split in 2 steps: first indicate the NaMi number and then eventually complete the participant data:
The design is made to make a few requests as possible against the NaMi API:
Moreover this feature is quite heavy on privacy : the search is restricted to NaMi number belonging to the current troop.
And lastly, the implementation tries to be robust: on API failure, the empty form is still displayed (and everything is unit-tested ;-)