-
Notifications
You must be signed in to change notification settings - Fork 145
feat: Support verify with branch #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support verify with branch #302
Conversation
| ignore = E226,E302,E41,W503 | ||
| max-line-length = 160 | ||
| max-complexity = 10 | ||
| max-complexity = 15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😆 did this tip us over the edge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested this but in terms of adding a param to the ruby engine this seems legit. I can test early next week and get a release done. To Matt's point do we know why it has bumped to 15? Quite a jump. Assume it's the extra param?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the extra parameter breaks complexity rules, same in #300
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can drop it to 12
./pact/verify_wrapper.py:136:5: C901 'VerifyWrapper.call_verify' is too complex (11)
./pact/broker.py:51:5: C901 'Broker.publish' is too complex (12)
|
Tested this out locally and looks good to me, nice work @B3nnyL |
Issue:
#267
Context:
Actual verification
broken url