Skip to content

fix: preferences sync#49

Merged
scanash00 merged 1 commit into
paddinglabs:mainfrom
hacdias:fix/preferences
Feb 17, 2026
Merged

fix: preferences sync#49
scanash00 merged 1 commit into
paddinglabs:mainfrom
hacdias:fix/preferences

Conversation

@hacdias
Copy link
Copy Markdown
Contributor

@hacdias hacdias commented Feb 16, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue where the external link warning preference was not being properly saved to the database.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

A boolean field DisableExternalLinkWarning is added to the preference upsert operation in the CollectionPreferences sync path, mapping from the incoming record to the database layer without control flow changes.

Changes

Cohort / File(s) Summary
Preference Field Mapping
backend/internal/sync/service.go
Added DisableExternalLinkWarning field assignment to db.Preferences upsert call in upsertRecord function for CollectionPreferences path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A flag hops into the database store,
DisableExternalLinkWarning joins the core,
Simple and swift, no flows to rework,
Just one little line to complete the work! ✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: preferences sync' accurately describes the main change: adding the DisableExternalLinkWarning field to the preferences upsert call to fix preferences synchronization.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@scanash00 scanash00 merged commit 3801467 into paddinglabs:main Feb 17, 2026
1 check passed
@scanash00
Copy link
Copy Markdown
Contributor

Thanks lol, i've been trying to fix this for a while but never had the time to

@hacdias hacdias deleted the fix/preferences branch February 17, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants