Skip to content

display error message on request failure #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scanash00 merged 3 commits into from
Apr 27, 2026
Merged

display error message on request failure #55

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e32a67
Display error message in popup on request failure
luminousherbs Apr 25, 2026
8e9a1f0
etc
luminousherbs Apr 26, 2026
97c5914
Merge branch 'main' of https://github.com/luminousherbs/margin
luminousherbs Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions extension/src/components/sidepanel/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,10 @@ export function App() {
setTags([]);
loadAnnotations();
} else {
alert('Failed to post annotation');
const errorMessage = result.error
? `Failed to post annotation: ${result.error}`
: 'Failed to post annotation';
alert(errorMessage);
}
} catch (error) {
console.error('Post error:', error);
Expand All @@ -333,7 +336,10 @@ export function App() {
setBookmarkTags([]);
setShowBookmarkTags(false);
} else {
alert('Failed to bookmark page');
const errorMessage = result.error
? `Failed to bookmark page: ${result.error}`
: 'Failed to bookmark page';
alert(errorMessage);
}
} catch (error) {
console.error('Bookmark error:', error);
Expand Down