Fix M2 flag packing in wh_She_GenerateLoadableKey and add test cases#1
Draft
padelsbach wants to merge 1 commit intoshe-load-key-testsfrom
Draft
Fix M2 flag packing in wh_She_GenerateLoadableKey and add test cases#1padelsbach wants to merge 1 commit intoshe-load-key-testsfrom
padelsbach wants to merge 1 commit intoshe-load-key-testsfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds upon PR wolfSSL#335 and should be merged after that.
The SHE client packed flags & 0x0f into M2[3] bits 0-3 with flags << 0, but the server's _PopFlags reads M2[3] bits 0-3 as flag bits 4-7 of the returned value (and M2[4] bit 7 as flag bit 0). So WH_SHE_FLAG_WILDCARD = 1<<4 on the client side never reached the wire position _PopFlags expects.
Added test cases with flags
WH_SHE_FLAG_WILDCARDandWH_SHE_FLAG_WRITE_PROTECT