Skip to content

bug fix #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
padlocks merged 3 commits into from
Mar 2, 2022
Merged

bug fix #3

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
500c2b1
hotfix for empty customStatus changes
padlocks Mar 2, 2022
64e8e7f
Merge branch 'dev' of https://github.com/padlocks/SPPK into dev
padlocks Mar 2, 2022
6acb591
fix for diff sometimes including a change and a previous change and n…
padlocks Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ generateResponse = async (target, data) => {
// find the "primary" fronter to move to the first element in the list
let primary = await findPrimary()
if (primary && fronters.length > 1) {
if (fronters.indexOf(primary) > 0) {
if (fronters.indexOf(primary) >= 0) {
fronters.splice(fronters.indexOf(primary), 1)
fronters.unshift(primary)

Expand Down Expand Up @@ -234,8 +234,8 @@ determineAction = async (eventData, frontData = []) => {
// get the difference between cached history and current front
let diff = await calculateDiff(cache.frontHistory, frontData)
// we handle one thing at a time, although this should be expanded since you can modify multiple custom statuses at once
if (diff.length == 1) {
if (diff[0].content.customStatus) {
if (diff.length >= 1) {
if (diff[0].content.customStatus || eventData.content.customStatus) {
// check if customStatus value is in cache
let foundInCache = Object.keys(cache.frontHistory).filter((key) => {
return cache.frontHistory[key] === diff[0].content.customStatus
Expand All @@ -247,6 +247,7 @@ determineAction = async (eventData, frontData = []) => {
}
}
else {
if (eventData.content.customStatus == '') return 'customStatus'
console.error('::SimplyWS:: Unrecognized diff: ' + JSON.stringify(diff))
}
}
Expand Down