🥅 Fall back to the backup data if the API request fails #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just to format the API backup file.
To include the Gitmoji API backup file.
Codecov Report
@@ Coverage Diff @@
## main #10 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 41 49 +8
Branches 3 4 +1
=========================================
+ Hits 41 49 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
paduszyk
deleted the
feature/no-ref/fall-back-to-backup-data-if-api-request-fails
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the
gitmojis.core.fetch_guidefunction so that it returns theGuideobject created from a local copy of the Gitmoji API data in case of any issues with the API request.The backup data are stored in a local static JSON file added in this PR as well.
Parsing/decoding of that JSON file is handled by
jsonbuilt-in library.