Skip to content

Conversation

@paduszyk
Copy link
Owner

@paduszyk paduszyk commented Nov 3, 2023

Description

This updates gitmojis.core.fetch_guide (#9) by adding the use_backup keyword argument to its signature. The argument enables the user to decide whether the function should fall back to the backup data if the API request fails.

To adopt the change in the CLI, the --use-backup option is added to the gitmojis_cli hook (#11).

@paduszyk paduszyk added the feature New feature or request label Nov 3, 2023
@paduszyk paduszyk self-assigned this Nov 3, 2023
@codecov
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #14 (f4660ce) into main (4bd174f) will not change coverage.
The diff coverage is 100.00%.

❗ Current head f4660ce differs from pull request most recent head 2afba9b. Consider uploading reports for the commit 2afba9b to get more accurate results

@@            Coverage Diff            @@
##              main       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines           73        76    +3     
  Branches        12        14    +2     
=========================================
+ Hits            73        76    +3     
Files Coverage Δ
src/gitmojis/cli/__init__.py 100.00% <100.00%> (ø)
src/gitmojis/core.py 100.00% <100.00%> (ø)
src/gitmojis/exceptions.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@paduszyk paduszyk force-pushed the feature/no-ref/allow-selecting-whether-to-use-backup branch from f4660ce to 2afba9b Compare November 3, 2023 10:49
@paduszyk paduszyk merged commit f44715b into main Nov 3, 2023
@paduszyk paduszyk deleted the feature/no-ref/allow-selecting-whether-to-use-backup branch November 3, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants