Conversation
This will display a random Pokemon's name, followed by an exclamation point (ex. "Bulbasaur!").
Madmadness65
added
Localization
It even says to do so whenever weight multipliers are adjusted...
damocleas
changed the title
4 tasks
Collaborator
Author
|
meant to do the locales one oops |
This makes the specific April Fools splash message functional. Also fixed a linter issue with the randomPokemon code.
damocleas
changed the title
Madmadness65
previously approved these changes
Mar 27, 2025
CodeTappert
previously approved these changes
Mar 27, 2025
CodeTappert
reviewed
Mar 27, 2025
CodeTappert
reviewed
Mar 27, 2025
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Collaborator
Author
|
changes made, one of them isn't even here, doesn't affect this PR, that will be fixed in the locales separately and doesn't halt this one |
Madmadness65
approved these changes
Mar 27, 2025
DayKev
approved these changes
Mar 28, 2025
SirzBenjie
pushed a commit
to SirzBenjie/pokerogue
that referenced
this pull request
Mar 29, 2025
* Update splash-messages.ts 1 * Add Pokemon name splash text This will display a random Pokemon's name, followed by an exclamation point (ex. "Bulbasaur!"). * Make Pokemon name splash message weighted * Update splash-messages.ts * Update splash-messages.ts * fix trailing spaces * Update splash-messages.ts * Update splash-messages.ts * Add splashes which use random Pokemon * Update splash message tests * Update splash-messages.ts * Update splash-messages.ts * Missing comma * Fix length on test It even says to do so whenever weight multipliers are adjusted... * Update splash-messages.ts * add missing prefix thing * adjusted comment in splash_messages.test.ts * Update splash-messages.ts * fix blank line * Add gender splash message code This makes the specific April Fools splash message functional. Also fixed a linter issue with the randomPokemon code. * Update title-ui-handler.ts changed battles won fallback number to -1 * Update splash-messages.ts * changed afd to 2 days * Update splash_messages.test.ts * Update src/data/splash-messages.ts Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com> --------- Co-authored-by: Madmadness65 <blaze.the.fireman@gmail.com> Co-authored-by: Madmadness65 <59298170+Madmadness65@users.noreply.github.com> Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com> Signed-off-by: Sirz Benjie <142067137+SirzBenjie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
More splash texts!
Seasonal/Event splash texts now actually enabled!
Why am I making these changes?
People love Splash Texts. Adding some more since it has been ~4+ months!
What are the changes from a developer perspective?
Upped the weight multiplier for Battles Won from 10 -> 15
Updated 'Battles Won fallback number' to -1
Updated the dates for all of the seasonal splash texts
Added more imports to title-ui-handler.ts
New "randomPokemon" for splash text, calls a random pokemon using its translated name
New "genderSplash", calls the name of the player's character that will be from https://github.com/pagefaultgames/pokerogue-locales/blob/main/en/trainer-names.json
Screenshots/Videos
Video of the Pokemon name splash message in action
splash.text.mp4
How to test the changes?
Merge to a local with the below, change frequency numbers or comment some out if you're having trouble checking some.
https://github.com/damocleas/pokerogue-locales/blob/main/en/splash-texts.json
Checklist
betaas my base branchnpm run test)npm run create-test) or updated existing tests related to the PR's changes?Are there any localization additions or changes? If so: