[GitHub] Add path filters to avoid unnecessarily re-running tests#5497
Merged
SirzBenjie merged 4 commits intopagefaultgames:betafrom Apr 4, 2025
Merged
Conversation
DayKev
reviewed
Mar 8, 2025
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
emdeann
reviewed
Mar 18, 2025
dd2e92a to
fb3dab2
Compare
DayKev
approved these changes
Mar 31, 2025
308e416 to
7317b5a
Compare
Madmadness65
approved these changes
Apr 4, 2025
72a9d0f to
fd86122
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
N/A
Why am I making these changes?
Part of the test refactor (sort of). We do not need to re-run tests in commits that only change files that cannot impact tests (e.g. the README file). These tests are long running.
What are the changes from a developer perspective?
In summary, the test github action will only re-run when source code files, test files, any file that can impact the build, or the test workflow file itself has changes.
Accomplished by added the following paths filter to
.github/workflows/tests.ymlScreenshots/Videos
N/A
How to test the changes?
You'd have to make a commit and open a pull request that only changes a file, like README.md, to verify that the tests aren't automatically re-run. The, make a commit and open a pull request that changes any source code file and verify tests are still re-run.
Checklist
betaas my base branch[ ] Have I tested the changes manually?[ ] Are all unit tests still passing? (npm run test)[ ] Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?[ ] Have I provided screenshots/videos of the changes (if applicable)?[ ] Have I made sure that any UI change works for both UI themes (default and legacy)?