Skip to content

[Sprite] [Item] Weather/Terrain Extender Item Sprite#5542

Merged
damocleas merged 7 commits intopagefaultgames:betafrom
Unicornpowerstar:Terrain/weather-extender-item-
Mar 27, 2025
Merged

[Sprite] [Item] Weather/Terrain Extender Item Sprite#5542
damocleas merged 7 commits intopagefaultgames:betafrom
Unicornpowerstar:Terrain/weather-extender-item-

Conversation

@Unicornpowerstar
Copy link
Contributor

@Unicornpowerstar Unicornpowerstar commented Mar 19, 2025

What are the changes from a developer perspective?

All item pngs have now been properly index not just the mapping but the colors as well.
the results with this is easier loading time on mobile and could help reduce the game failing to load item pngs on mobile with high game speeds.

Screenshots/Videos

How to test the changes?

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

@Unicornpowerstar Unicornpowerstar added Enhancement New feature or request Item Affects items Sprite/Animation For issues/PRs related to graphics labels Mar 19, 2025
@damocleas damocleas changed the title Terrain/weather extender item [Sprite] [Item] Weather/Terrain Extender Item Sprite Mar 20, 2025
@Unicornpowerstar Unicornpowerstar marked this pull request as ready for review March 26, 2025 18:13
@Unicornpowerstar Unicornpowerstar requested a review from a team as a code owner March 26, 2025 18:13
Madmadness65 and others added 2 commits March 26, 2025 13:55
@damocleas damocleas merged commit 0b1f324 into pagefaultgames:beta Mar 27, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request Item Affects items Sprite/Animation For issues/PRs related to graphics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants