Skip to content
This repository was archived by the owner on Mar 13, 2020. It is now read-only.

aws lambda as source - increase read timeout from default of 60 seconds to 200 seconds #75

Merged
merged 2 commits into from
Oct 9, 2019
Merged

aws lambda as source - increase read timeout from default of 60 seconds to 200 seconds #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d7b492
aws lambda as source - increase read timeout from default of 60 secon…
ChintanRaval Oct 9, 2019
2c40c9c
bump release version
ChintanRaval Oct 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions rdl/data_sources/AWSLambdaDataSource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import boto3
import time
import datetime

from botocore.client import Config
from rdl.data_sources.ChangeTrackingInfo import ChangeTrackingInfo
from rdl.data_sources.SourceTableInfo import SourceTableInfo
from rdl.shared import Providers, Constants
Expand Down Expand Up @@ -47,7 +47,8 @@ def __init__(self, connection_string, logger=None):
)

self.aws_lambda_client = self.__get_aws_client(
self.AWS_SERVICE_LAMBDA, role_credentials
self.AWS_SERVICE_LAMBDA, role_credentials,
Config(read_timeout=200)
Copy link
Collaborator

@waltaro waltaro Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

200? Not increments of 60?

Copy link
Collaborator Author

@ChintanRaval ChintanRaval Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elexisvenator

)
self.aws_s3_client = self.__get_aws_client(
self.AWS_SERVICE_S3, role_credentials
Expand Down Expand Up @@ -182,12 +183,13 @@ def __assume_role(self, role_arn, session_name):

return role_credentials

def __get_aws_client(self, service, credentials):
def __get_aws_client(self, service, credentials, config=None):
return boto3.client(
service_name=service,
aws_access_key_id=credentials["AccessKeyId"],
aws_secret_access_key=credentials["SecretAccessKey"],
aws_session_token=credentials["SessionToken"],
config=config
)

def __refresh_aws_clients_if_expired(self):
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

setup(
name="rdl",
version="0.1.14-beta",
version="0.1.24-beta",
packages=find_packages(),
install_requires=[
"numpy==1.16.2",
Expand Down