-
Notifications
You must be signed in to change notification settings - Fork 12
Closed
Description
Bug
apr validate model.gguf --strict accepts the --strict flag but silently ignores it for non-APR formats (GGUF, SafeTensors).
Root Cause
In crates/apr-cli/src/commands/validate.rs, the dispatch at line 47 doesn't pass strict to the Rosetta validation path:
match format {
FormatType::Apr => run_apr_validation(path, quality, strict, min_score, json),
FormatType::Gguf | FormatType::SafeTensors => {
run_rosetta_validation(path, format, quality, json) // strict NOT passed
}
}The run_rosetta_validation() function signature (line 88) doesn't even accept strict.
Additionally, --strict is also unused in the APR path — print_summary() at line 348 has _strict: bool (underscore prefix = intentionally unused).
Expected Behavior
--strict should fail validation on warnings (NaN count > 0, all-zero tensors, etc.) instead of only failing on hard errors.
Fix
- Add
strictparameter torun_rosetta_validation() - When strict=true, fail if there are any NaN/Inf counts or all-zero tensors
- Implement strict logic in APR path too (fail on warnings, not just failures)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels