Skip to content

profile: 5 flags silently ignored (threshold, compare-hf, energy, callgraph, fail-on-naive) #517

@noahgift

Description

@noahgift

Bug

In diff_benchmark_report.rs (included by profile.rs), the run() function at lines 21-26 has 5 parameters with underscore prefixes:

  1. _naive_threshold: f64 (--threshold)
  2. _compare_hf: Option<&str> (--compare-hf)
  3. _energy: bool (--energy)
  4. _callgraph: bool (--callgraph)
  5. _fail_on_naive: bool (--fail-on-naive)

All accepted by CLI, passed through dispatch, but silently discarded.

Fix

Reject unimplemented flags with explicit errors rather than silently ignoring them.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions