chore(theater): delete 186 orphan contract-scaffold modules (PMAT-THEATER-TRIAGE-001)#2302
Merged
Conversation
…/ (PMAT-THEATER-TRIAGE-001) The Fable review's rank-16 target. crates/aprender-core/src/format/ holds 189 numbered `*_NNN_NNN.rs` "contract-falsification" modules from an abandoned PARTIAL-discharge scaffolding campaign (#1644 "batch 5" et al). 186 of them are ORPHANS: NO `mod`/`include!`/ `#[path]` reference anywhere, no automod, build.rs doesn't wire them, 0 refs from contracts//tests//examples//docs/ or the enforced pmat gates (.pmat-gates.toml/pmat.toml). They are NEVER COMPILED — their ~5,200 `#[test]`s never run, inflating the advertised test count with pure theater. Proven build-neutral: `cargo check -p aprender --lib` exits 0 after deletion (they were never part of the build). The 3 numbered files that ARE live (`qa_002_006`, `pub_cli_002_004`, `aprfi_001_003`, declared in format/mod.rs) are KEPT — caught by using cargo as the oracle after an initial over-broad glob swept them in. The only side effect is a stale pmat semantic index (.pmat/*.idx, gitignored) → re-sync with `pmat embed sync`. Non-format orphans (test-lib/serve-cli, ~96 files) are triaged separately. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fable rank-16 — kill the theater
crates/aprender-core/src/format/holds 189 numbered*_NNN_NNN.rs"contract-falsification" modules from an abandoned PARTIAL-discharge scaffolding campaign (#1644 "batch 5" et al). 186 are orphans — never referenced bymod/include!/#[path], no automod,build.rsdoesn't wire them, and 0 refs fromcontracts/,tests/,examples/,docs/, or the enforced pmat gates. They are never compiled → their 5,172#[test]s never run, inflating the advertised test count with pure theater — exactly what the Fable review's rank-16 targets.Proven build-neutral
cargo check -p aprender --libexits 0 after deletion — they were never part of the build.False-positives caught by using cargo as the oracle
An initial over-broad glob swept in 3 files that ARE live (
qa_002_006,pub_cli_002_004,aprfi_001_003, declared informat/mod.rs).cargo checkflagged them (E0583); they're kept. Only the 186 truly-dead files are deleted.Diligence
mod/include!/#[path](whole crate)contracts/YAMLtests/·examples/·benches/docs/·book/.pmat-gates.toml,pmat.toml).pmat/*.idx, gitignored cache)pmat embed syncNon-format orphans (test-lib / serve-cli, ~96 files) are triaged separately — some may warrant wiring-in rather than deletion.
🤖 Generated with Claude Code