fix: streaming APR import + mmap reader (realizar#136)#418
Merged
Conversation
…H-129) - REALIZR_MAX_SEQ_LEN: override max sequence length (default 2048) - REALIZR_FREE_CPU_WEIGHTS=1: free CPU weight copies after GPU preload - Use with_max_seq_len instead of new() for flexible KV cache sizing Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…(Refs GH-176) Replace benchmark_bricks() derived estimates (fugazi `*` suffixed scores) with brick_scores_from_profiler() that reads actual GPU-synced timing from trueno's BrickProfiler via all_brick_stats(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ls (Refs realizar#136) AprV2StreamingWriter writes tensor data to temp file incrementally (peak RAM = 1 shard ~5GB, was 134GB). list_tensors() uses MappedFile + AprV2ReaderRef for APR v2 files (10.9MB RSS on 67GB file, was 89GB). Also fixes: pre-existing model_config.rs architecture field, gguf.rs BrickProfiler API breakage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apr tensors:list_tensors()usesMappedFile+AprV2ReaderReffor APR v2 files. 10.9MB RSS on 67GB file (was 89GB → swap storm).model_config.rsarchitecture field +gguf.rsBrickProfiler API breakage.Dogfood results
Contract
streaming-reader-v1.yaml— FALSIFY-MMAP-001 verified.Test plan
apr tensorson 67GB .apr: 10.9MB RSS (FALSIFY-MMAP-001)cargo build --release --lib)pv validate contracts/streaming-reader-v1.yamlpasses🤖 Generated with Claude Code