feat: PMAT-546 Architecture parity + gate job fix + 18 new tests#733
Merged
feat: PMAT-546 Architecture parity + gate job fix + 18 new tests#733
Conversation
…falsification tests Five-Whys: Architecture enum had 14 non-Auto variants but only 12 matching model-family YAML contracts. 5 YAML families (falcon_h1, mamba, moonshine, openelm, rwkv7) had no Architecture variant. 2 enum variants (GptNeoX, Opt) had no YAML contract. Root cause: implicit assumption that these would stay in sync without enforcement. Changes: - Add 5 Architecture variants: FalconH1, Mamba, Moonshine, OpenElm, Rwkv7 - Create 2 YAML contracts: gptneox.yaml, opt.yaml - Create provable contract: model-family-parity-v1.yaml (5 falsification conds) - Add 6 parity tests in converter_types_tests_parity.rs - Update from_model_type(), is_llm(), display_name(), map_name() for all - Fix pre-existing cargo fmt in 5 crates (Toyota Way) - Update 1 pre-existing test (mamba/rwkv now recognized, not unknown) - 13,011 aprender-core tests pass, 1,371 contract tests pass Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Transitive dep via quickcheck (test-only). Not in production path. Advisory: rand 0.10.0 is unsound with a custom logger using rand::rng(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
10 new wasmtime advisories published 2026-04-09 affect wasmtime 27.0.0 (test-only dep via aprender-test-lib). Not in production path. Upgrade to wasmtime 43 tracked in PR #731. New exemptions: RUSTSEC-2026-{0085,0086,0088,0089,0091,0092,0093,0094,0095,0096} Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Extend RosettaStone::infer_architecture_from_tensors() to detect: - Mamba (mixer.in_proj/out_proj patterns) - RWKV (rwkv.blocks.* patterns) - GPT-NeoX (gpt_neox.* prefix, fused query_key_value) - OPT (model.decoder.layers.* prefix) - BERT (bert.* prefix) Previously only detected: GPT-2, Qwen2, LLaMA, generic transformer. 10 new falsification tests in tests_arch_inference.rs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add Mamba (mixer.*) and RWKV (rwkv.blocks.*) detection to infer_architecture_from_names() in the import pipeline. Previously only the rosetta inspector detected these patterns. 2 new tests. aprender-core now 13,025 tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Five-Whys: PR #731 all checks pass but auto-merge blocked. 1. Why blocked? Org ruleset "Green Main" requires check named "gate" 2. Why not matching? Reusable workflow produces "ci / gate" (prefixed) 3. Why prefixed? GitHub adds caller job name ("ci") as namespace 4. Why doesn't ruleset match? Rulesets require exact context name 5. Why not fixed before? PR #726 merged via admin bypass Fix: Add top-level "gate" job that checks ci + workspace-test results. Also add chown post-step from PR #731 to prevent root-owned files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
noahgift
force-pushed
the
feat/pmat-next
branch
from
2796527 to
b42e790
Compare
noahgift
changed the title
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model-family-parity-v1.yamlwith 5 falsification conditionsgatejob in ci.yml — fixes org ruleset blocking auto-mergecargo fmtin 5 pre-existing cratesFive-Whys (Architecture Parity)
Five-Whys (Gate Job)
gatejob. Fixed.Test Results
cargo fmt --check: cleancargo deny check advisories: cleanTest plan
cargo test -p aprender-core --lib— 13,023 passcargo test -p aprender-contracts --lib— 1,371 passcargo clippy -p aprender-core --lib -- -D warnings— cleancargo fmt --all -- --check— cleancargo deny check advisories— clean🤖 Generated with Claude Code