Added proper default options for Azure connection#172
Conversation
|
Thansk for creating this PR and supporting our project. |
I still get the little popup once in a while. I think it is controlled via the /**
* Whether we should show the indication to sign in in the Accounts menu.
*
* If false, the user will be shown a badge on the Accounts menu with an option to sign in for the extension.
* If true, no indication will be shown.
*
* Defaults to false.
*
* Note: you cannot use this option with any other options that prompt the user like {@link AuthenticationGetSessionOptions.createIfNone createIfNone}.
*/
silent?: boolean;Also I have seen, that you are also from Austria :) Greetings from Vienna! |
|
to be honest i could not figure out yet when VSCode decides to show a pop or when it just uses the cached credentials. But as you say, it seems it is not prompting each and every time anymore |
|
we (paiqo) are also based in Vienna :) |
Hi @gbrueckl,
Thanks for this great extension, we use it daily in our company!
Recently we had to switch from PAT to Azure Login, and I encountered some errors with the Azure Login type, and was able to boil it down to the default options of the
vscode.AuthenticationGetSessionOptions. I needed to set thecreateIfNoneoption totrue, otherwise no session will be created in our case. I left all the other values set to their default valuefalse. I think we can leave the optioncreateIfNoneontruesince it seems like a sensible default value for everyone, but we can also create an option in the workspace settings.Let me know what you think :)
Best regards
Chris