Skip to content

test: replace deprecated ReactDOM functions (fixes #7167)#7343

Merged
ggdouglas merged 2 commits intopalantir:developfrom
bvandercar-vt:test/remove-reactdom-deprecated-function
Mar 20, 2025
Merged

test: replace deprecated ReactDOM functions (fixes #7167)#7343
ggdouglas merged 2 commits intopalantir:developfrom
bvandercar-vt:test/remove-reactdom-deprecated-function

Conversation

@bvandercar-vt
Copy link
Contributor

@bvandercar-vt bvandercar-vt commented Mar 13, 2025

Fixes #7167 by syncing up all the containerElement code to be the same, using enzyme mount instead of ReactDOM.render, and using React.act.

Also enabled un-skipping the tests that were skipped as part of #1794, these are passing now.

@changelog-app
Copy link

changelog-app bot commented Mar 13, 2025

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

test: remove deprecated ReactDOM.unmountComponentAtNode


Generate changelog in packages/datetime/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

test: remove deprecated ReactDOM.unmountComponentAtNode


Generate changelog in packages/datetime2/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

test: remove deprecated ReactDOM.unmountComponentAtNode


Generate changelog in packages/select/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

test: remove deprecated ReactDOM.unmountComponentAtNode


Generate changelog in packages/table/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

test: remove deprecated ReactDOM.unmountComponentAtNode


Check the box to generate changelog(s)

  • Generate changelog entry

@bvandercar-vt bvandercar-vt force-pushed the test/remove-reactdom-deprecated-function branch 9 times, most recently from 125571b to 53cd824 Compare March 13, 2025 04:06
@bvandercar-vt bvandercar-vt force-pushed the test/remove-reactdom-deprecated-function branch from 53cd824 to cc7315d Compare March 13, 2025 05:25
@bvandercar-vt bvandercar-vt changed the title test: remove deprecated ReactDOM.unmountComponentAtNode test: remove deprecated ReactDOM.unmountComponentAtNode (fixes #7167) Mar 13, 2025
@bvandercar-vt bvandercar-vt changed the title test: remove deprecated ReactDOM.unmountComponentAtNode (fixes #7167) test: replace deprecated ReactDOM functions (fixes #7167) Mar 13, 2025
@bvandercar-vt bvandercar-vt force-pushed the test/remove-reactdom-deprecated-function branch 16 times, most recently from 94e1ab9 to 4e995dc Compare March 13, 2025 18:20
@bvandercar-vt bvandercar-vt force-pushed the test/remove-reactdom-deprecated-function branch 11 times, most recently from 7128581 to b660c29 Compare March 14, 2025 00:17
@bvandercar-vt bvandercar-vt force-pushed the test/remove-reactdom-deprecated-function branch from 26c4ccb to 3d4d612 Compare March 14, 2025 00:58
@bvandercar-vt
Copy link
Contributor Author

All passing!

@ggdouglas ggdouglas self-requested a review March 17, 2025 17:55
@bvandercar-vt bvandercar-vt force-pushed the test/remove-reactdom-deprecated-function branch from cf7313f to 0c2f194 Compare March 19, 2025 16:25
Copy link
Contributor

@ggdouglas ggdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking through, this seems reasonable to me. Eventually, we want to get these tests migrated over to RTL. This is a great first step towards that and general React 18 compatibility though. Thanks for this!

@ggdouglas ggdouglas merged commit 9cf86c3 into palantir:develop Mar 20, 2025
13 of 19 checks passed
@bvandercar-vt bvandercar-vt deleted the test/remove-reactdom-deprecated-function branch March 21, 2025 17:54
jscheiny added a commit that referenced this pull request Mar 28, 2025
jscheiny added a commit that referenced this pull request Mar 28, 2025
Co-authored-by: Blake V <87083504+bvandercar-vt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace deprecated ReactDOM methods in tests

2 participants