break(OverlayToaster): Use React 18 createRoot for rendering via createAsync#7390
Merged
break(OverlayToaster): Use React 18 createRoot for rendering via createAsync#7390
Conversation
break(OverlayToaster): Use React 18 createRoot for rendering via createAsyncBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
remove console.logBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
ggdouglas
reviewed
Mar 27, 2025
| // toaster.getToasts().map(t => t.message), | ||
| // ["six", "one"], | ||
| // ); | ||
| // }); |
Contributor
There was a problem hiding this comment.
nit: remove commented out code
Uncomment testBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Merge remote-tracking branch 'origin/bp6' into js/bp6/overlay-toaster-react-18Build artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
ggdouglas
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7166
Changes proposed in this pull request:
In this PR we make two breaking changes:
domUnmounterfield forOverlayToasterCreateOptions. This fields was never used anyways, so this is just clean up.domRenderervalue forOverlayToaster.createAsyncuse the new ReactcreateRootmethod for rendering.In a follow up PR, we will consolidate
createandcreateAsyncto make them have the same behavior and then deprecatecreateAsync.