Skip to content

Comments

[datetime] Rename dateInput2MigrationUtils to dateInputMigrationUtils#7396

Merged
ggdouglas merged 2 commits intobp6from
gdouglas/date-input-migration-utils-rename
Mar 28, 2025
Merged

[datetime] Rename dateInput2MigrationUtils to dateInputMigrationUtils#7396
ggdouglas merged 2 commits intobp6from
gdouglas/date-input-migration-utils-rename

Conversation

@ggdouglas
Copy link
Contributor

Proposed changes:

  • Rename dateInput2MigrationUtils to dateInputMigrationUtils when exported from @blueprintjs/datetime
  • Alias the re-export from @blueprintjs/datetime2

@svc-palantir-github
Copy link

Rename dateInput2MigrationUtils -> dateInputMigrationUtils

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas force-pushed the gdouglas/date-input-migration-utils-rename branch from 19c34a1 to dfd6c6b Compare March 26, 2025 16:34
@svc-palantir-github
Copy link

Rename dateInput2MigrationUtils -> dateInputMigrationUtils

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas force-pushed the gdouglas/date-input-migration-utils-rename branch from dfd6c6b to ee7a984 Compare March 26, 2025 17:16
@svc-palantir-github
Copy link

Rename dateInput2MigrationUtils -> dateInputMigrationUtils

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

import * as DateInput2MigrationUtils from "./dateInput2MigrationUtils";
export { DateInput2MigrationUtils };
import * as DateInputMigrationUtils from "./dateInputMigrationUtils";
export { DateInputMigrationUtils };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we export DateInput2MigrationUtils as a deprecated alias?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah, good call. I'm honestly not sure if there was a plan here for these other than having people eventually port over their components. We should still probably mark as deprecated though.

1e203bf

@svc-palantir-github
Copy link

Add deprecation notice for DateInputMigrationUtils

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas requested a review from jscheiny March 26, 2025 19:21
@ggdouglas ggdouglas merged commit 1287f02 into bp6 Mar 28, 2025
14 checks passed
@ggdouglas ggdouglas deleted the gdouglas/date-input-migration-utils-rename branch March 28, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants