[core] Add Storybook stories for Toast by mm-wang · Pull Request #7969 · palantir/blueprint

mm-wang · 2026-03-25T15:51:14Z

Summary

Extracted Storybook stories for Toast component
Stories provide visual regression testing coverage

Files

Toast.stories.tsx

Test plan

Verify stories render correctly in Storybook
Check all story variants display properly in light and dark themes

🤖 Generated with Claude Code

blueprint-previews · 2026-03-25T16:03:18Z

[core] Add Storybook stories for Toast

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

blueprint-previews · 2026-03-25T17:54:52Z

[core] Add Storybook stories for Toast

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

blueprint-previews · 2026-03-26T17:45:18Z

Remove redundant AllIntents story, run pnpm format

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

blueprint-previews · 2026-03-26T18:43:42Z

Remove redundant AllIntents story, run pnpm format

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

blueprint-previews · 2026-03-26T19:05:53Z

Replace native HTML elements with Blueprint components

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

blueprint-previews · 2026-04-03T17:44:31Z

Replace native HTML elements with Blueprint components

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

blueprint-previews · 2026-04-03T22:37:40Z

Replace native HTML elements with Blueprint components

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a new Storybook story file for the Toast component to support visual regression coverage and interactive exploration of props.

Changes:

Introduces Toast.stories.tsx with default, intent matrix, icon variants, and a playground story
Configures Storybook controls/args and a centering decorator for consistent rendering

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-03T22:53:59Z

+            <Toast {...args} icon="tick-circle" intent="success" message="File saved successfully" />
+            <Toast {...args} icon="warning-sign" intent="warning" message="Connection is unstable" />
+            <Toast {...args} icon="error" intent="danger" message="Failed to save changes" />
+            <Toast {...args} icon="info-sign" intent="primary" message="New update available" />


intent is set using string literals in multiple places while the stories elsewhere use Intent enum values (e.g., Intent.NONE). If Toast’s intent prop is typed as Intent (string enum), these string literals will not type-check. Use Intent.SUCCESS, Intent.WARNING, Intent.DANGER, Intent.PRIMARY, etc., for consistency and to satisfy the prop type.

Copilot · 2026-04-03T22:53:59Z

+    args: {
+        message: "Playground toast message",
+        icon: "info-sign",
+        intent: "primary",


intent is set using string literals in multiple places while the stories elsewhere use Intent enum values (e.g., Intent.NONE). If Toast’s intent prop is typed as Intent (string enum), these string literals will not type-check. Use Intent.SUCCESS, Intent.WARNING, Intent.DANGER, Intent.PRIMARY, etc., for consistency and to satisfy the prop type.

Copilot · 2026-04-03T22:53:59Z

+        intent: { table: { disable: true } },
+    },
+    render: args => (
+        <div style={{ display: "flex", flexDirection: "column", gap: 8 }}>


The same inline style object is duplicated in multiple stories. Consider extracting it to a shared constant (e.g., const columnContainerStyle = { ... }) and reusing it to reduce duplication and keep visual/layout tweaks consistent across stories.

Copilot · 2026-04-03T22:54:00Z

+        icon: { table: { disable: true } },
+    },
+    render: args => (
+        <div style={{ display: "flex", flexDirection: "column", gap: 8 }}>


The same inline style object is duplicated in multiple stories. Consider extracting it to a shared constant (e.g., const columnContainerStyle = { ... }) and reusing it to reduce duplication and keep visual/layout tweaks consistent across stories.

blueprint-previews · 2026-04-03T23:00:48Z

Rename story

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

Files: - packages/core/src/components/toast/Toast.stories.tsx

- Consolidate stories following Button/Tag/Card pattern - Use standard naming: IntentExample, SizeExample, StateExample, etc. - Remove redundant/overly-specific stories - Remove DarkTheme stories (handled by Storybook globally) - Keep visual regression matrix and Playground stories Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

AllIntents does not add better examples beyond IntentExample. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Replace <h3>, <h4>, <h5> with Blueprint H3, H4, H5 - Replace <p> with Blueprint Text component - Remove intent !== none filter to show None intent in examples Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

blueprint-previews · 2026-04-16T19:23:07Z

Rename story

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

mm-wang force-pushed the stories/toast branch from a9e78dd to ccf1137 Compare March 25, 2026 17:42

mm-wang force-pushed the stories/toast branch from a22d5ee to 4c0206c Compare March 26, 2026 18:31

mm-wang added the no changelog label Mar 26, 2026

mm-wang force-pushed the stories/toast branch from b83bb63 to a936b4a Compare April 3, 2026 17:33

mm-wang force-pushed the stories/toast branch from a936b4a to eae69c1 Compare April 3, 2026 22:26

mm-wang force-pushed the stories/toast branch from 13cd75b to 2713c65 Compare April 3, 2026 22:47

mm-wang marked this pull request as ready for review April 3, 2026 22:47

Copilot AI review requested due to automatic review settings April 3, 2026 22:47

Copilot AI reviewed Apr 3, 2026

View reviewed changes

mm-wang and others added 6 commits April 16, 2026 12:10

[core] Add Storybook stories for Toast

a42b2b2

Files: - packages/core/src/components/toast/Toast.stories.tsx

Remove redundant AllIntents story, run pnpm format

61fee74

AllIntents does not add better examples beyond IntentExample. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Replace native HTML elements with Blueprint components

ff1187f

- Replace <h3>, <h4>, <h5> with Blueprint H3, H4, H5 - Replace <p> with Blueprint Text component - Remove intent !== none filter to show None intent in examples Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Updating the intent

4527a1d

Rename story

6bee3c9

mm-wang force-pushed the stories/toast branch from ade49ec to 6bee3c9 Compare April 16, 2026 19:10

Conversation

mm-wang commented Mar 25, 2026

Summary

Files

Test plan

Uh oh!

blueprint-previews bot commented Mar 25, 2026

[core] Add Storybook stories for Toast

Uh oh!

blueprint-previews bot commented Mar 25, 2026

[core] Add Storybook stories for Toast

Uh oh!

blueprint-previews bot commented Mar 26, 2026

Remove redundant AllIntents story, run pnpm format

Uh oh!

blueprint-previews bot commented Mar 26, 2026

Remove redundant AllIntents story, run pnpm format

Uh oh!

blueprint-previews bot commented Mar 26, 2026

Replace native HTML elements with Blueprint components

Uh oh!

blueprint-previews bot commented Apr 3, 2026

Replace native HTML elements with Blueprint components

Uh oh!

blueprint-previews bot commented Apr 3, 2026

Replace native HTML elements with Blueprint components

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

blueprint-previews bot commented Apr 3, 2026

Rename story

Uh oh!

blueprint-previews bot commented Apr 16, 2026

Rename story

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants