Add JSON annotations to ErrorType #130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uschi2000
reviewed
Sep 26, 2018
| @ImmutablesStyle | ||
| @JsonIgnoreProperties(ignoreUnknown = true) | ||
| @JsonSerialize(as = ImmutableErrorType.class) | ||
| @JsonDeserialize(as = ImmutableErrorType.class) |
There was a problem hiding this comment.
do we need deserialization?
There was a problem hiding this comment.
Not that I know of, is there harm in allow it to be deserialized?
There was a problem hiding this comment.
allow deserialization gives the impression that this is used as wire format, but that's not the case
|
Closing in favor of #131 |
This was referenced Sep 28, 2018
bulldozer-bot bot
pushed a commit
that referenced
this pull request
Dec 12, 2018
Revert of #92 Now that palantir/conjure-java-runtime#827 has merged and we are logging the error name in the exception mapper, we no longer need the injected arg here. With the injected args, the `ServiceExceptionMapper` logs would have both a `errorName` param and a `throwable0_errorType` param which is confusing and unnecessary. Also note that this parameter has never been logged properly (see #130), so this does not cause a regression in capability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ErrorTypeis a safe-loggable arg of aServiceException. Our internal logging library logs arg values using an object mapper. HoweverErrorTypedoes not have JSON property annotations and consequently always gets serialized as "{}", which is not very helpful.