Skip to content

Add JSON annotations to ErrorType #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add JSON annotations to ErrorType #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions errors/src/main/java/com/palantir/conjure/java/api/errors/ErrorType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@

package com.palantir.conjure.java.api.errors;

import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
import com.fasterxml.jackson.databind.annotation.JsonSerialize;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import org.immutables.value.Value;
Expand All @@ -28,6 +31,9 @@
*/
@Value.Immutable
@ImmutablesStyle
@JsonIgnoreProperties(ignoreUnknown = true)
@JsonSerialize(as = ImmutableErrorType.class)
@JsonDeserialize(as = ImmutableErrorType.class)
Copy link
Contributor

@uschi2000 uschi2000 Sep 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need deserialization?

Copy link
Member Author

@pkoenig10 pkoenig10 Sep 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I know of, is there harm in allow it to be deserialized?

Copy link
Contributor

@uschi2000 uschi2000 Sep 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allow deserialization gives the impression that this is used as wire format, but that's not the case

public abstract class ErrorType {

private static final String UPPER_CAMEL_CASE = "(([A-Z][a-z0-9]+)+)";
Expand Down
6 changes: 3 additions & 3 deletions errors/src/main/java/com/palantir/conjure/java/api/errors/SerializableError.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@
* the (specific sub-) type of error, an optional set of named parameters detailing the error condition. Intended to
* transport errors through RPC channels such as HTTP responses.
*/
@JsonDeserialize(builder = SerializableError.Builder.class)
@JsonSerialize(as = ImmutableSerializableError.class)
@Value.Immutable
@Value.Style(visibility = Value.Style.ImplementationVisibility.PACKAGE)
@ImmutablesStyle
@JsonIgnoreProperties(ignoreUnknown = true)
@JsonSerialize(as = ImmutableSerializableError.class)
@JsonDeserialize(builder = SerializableError.Builder.class)
public abstract class SerializableError implements Serializable {

/**
Expand Down