Change ImmutablesStyle's retention policy #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 24, 2019 18:08
dansanduleac
requested review from
dansanduleac
and removed request for
CRogers
| @Value.Immutable | ||
| @Value.Style(visibility = Value.Style.ImplementationVisibility.PACKAGE, jdkOnly = true) | ||
| @ImmutablesStyle | ||
| @Value.Style(overshadowImplementation = false) |
Contributor
There was a problem hiding this comment.
this is to preserve binary compat, otherwise revapi helpfully complains :)
Contributor
There was a problem hiding this comment.
do you know only this class was flagged for this and not all the others?
Contributor
|
👍 |
Collaborator
|
Released 2.7.0 |
Contributor
|
We also have an internal foundry/immutables-style repo with this class in it - would you mind making the matching change there too?? |
This was referenced Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Any class that's importing an immutable class with @ImmutablesStyle in the package, or directly with
@Value.Style(visibility = Value.Style.ImplementationVisibility.PACKAGE), but doesn't add 'org.immutables.value.Value' as compile dependency will get a warning during compilationAfter this PR
==COMMIT_MSG==
Change immutablesStyle's retention policy to be SOURCE instead of CLASS, and make SerializableError use it. This avoids compilation warnings for consumers that don't depend on immutables.
==COMMIT_MSG==