Don't warn about immutable bytes unless objects are generated#277
Merged
Conversation
The binary type is not allowed in headers/query/path parameters, and streaming types are used for the request and response bodies. The flag only modifies output of object generation.
markelliot
reviewed
Mar 10, 2019
Contributor
markelliot
left a comment
markelliot
left a comment
There was a problem hiding this comment.
Ideally we would only emit the warning when binary is used in an object definition.
Contributor
Author
|
I'd prefer to associate the warning with an infrastructure change (conjure generator upgrade or addition of conjure to a new project) than a change which adds a new endpoint. |
Contributor
|
👍 Not convinced this will really affect many projects (as I don't know of any use cases that just generate jersey), but associating with a conjure-generator upgrade seems like a fair enough justification |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The binary type is not allowed in headers/query/path parameters,
and streaming types are used for the request and response
bodies. The flag only modifies output of object generation.