[break] alias of binary return types is the same as binary return types#50
Conversation
|
Cool, looks like this achieves the short-term goal of enabling client and server-side streaming when a conjure endpoint returns an alias of binary! Kinda sad that we lose the alias name though - for a longer term solution, could we set up some kind of MessageBodyWriter somehow? |
| return delegate.visitSet(type); | ||
| } | ||
|
|
||
| private TypeName resolveReferenceType(com.palantir.conjure.spec.TypeName type) { |
There was a problem hiding this comment.
Can we dedupe this with the jersey version?
io.dropwizard:dropwizard-* = 1.3.1
|
@iamdanfox, what does the alias name of return binary give us? Wouldn't that just introduce some ambiguity around what the return type of the generated interfaces should behave, both the client and the server side? In the end, we want alias of binary return type to be always considered as |
qinfchen
changed the title
| public static TypeName resolveReturnReferenceType( | ||
| Map<com.palantir.conjure.spec.TypeName, TypeDefinition> types, | ||
| com.palantir.conjure.spec.TypeName type, | ||
| Supplier<TypeName> binaryTypeSupplier) { |
There was a problem hiding this comment.
Could this just be a plain TypeName instead of a supplier?
2 participants
Before this PR
alias of binary return type was treated differently as binary return type
After this PR
alias of binary return type is now treated the same as binary return type