[fix] Make the generated Union equals method symmetric#62
Merged
Conversation
iamdanfox
reviewed
Aug 31, 2018
|
|
||
| assertThat(unionTypeStringExample).isEqualTo(stringExample); | ||
| assertThat(unionTypeSet).isEqualTo(ImmutableSet.of("item")); | ||
| assertThat(unionTypeInt).isEqualTo(5); |
Contributor
There was a problem hiding this comment.
Should we actually keep these tests by make them say isNotEqualTo?
iamdanfox
approved these changes
Aug 31, 2018
Contributor
iamdanfox
left a comment
iamdanfox
left a comment
There was a problem hiding this comment.
LGTM. @markelliot just to double-check we haven't missed an optimization here!
markelliot
approved these changes
Aug 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
#61
The generated union equals method is not symmetric with the wrapper equals methods as described in the ticket above.
After this PR
The new generated method is only equal to other Union objects and not the wrapped types.