Simplify file loading in appconfig package#540
Merged
Conversation
In an older version of the GitHub API, getting the contents of a large file returned a 422 response. This is no longer the case. Instead, you get back a standard JSON response with an empty content field. Simplify the logic for loading config by making a single call to the contents API, then using the response content to determine if we need to use the direct download URL or not. I verified the API behavior against GitHub Enterprise 3.17, so I believe it will be the same on GitHub.com (this also matches the API docs.) I discovered this as part of trying to upgrade to go-github v85, which refactored the DownloadContents function in a way that broke our tests.
Generate changelog in
|
✅ Successfully generated changelog entry!Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. 🔄 Changelog entries were re-generated at Fri, 01 May 2026 20:59:11 UTC!📋Changelog Preview🐛 Fixes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an older version of the GitHub API, getting the contents of a large file returned a 422 response. This is no longer the case. Instead, you get back a standard JSON response with an empty content field. Simplify the logic for loading config by making a single call to the contents API, then using the response content to determine if we need to use the direct download URL or not.
I verified the API behavior against GitHub Enterprise 3.17, so I believe it will be the same on GitHub.com (this also matches the API docs.)
I discovered this as part of trying to upgrade to
go-githubv85, which refactored theDownloadContentsfunction in a way that broke our tests.I think this also fixes #227, although that wasn't the initial motivation.