Skip to content

Fix foundry-compute-modules[sources] package name in exception #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uz1pk merged 2 commits into from
May 30, 2025
Merged

Fix foundry-compute-modules[sources] package name in exception #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01c0e86
Update _sources.py
jettdc May 14, 2025
8ff5fab
Add generated changelog entries
svc-changelog May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/@unreleased/pr-35.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: fix
fix:
description: Fix foundry-compute-modules[sources] package name in exception
links:
- https://github.com/palantir/python-compute-module/pull/35
4 changes: 2 additions & 2 deletions compute_modules/sources_v2/_sources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def __get_on_prem_proxy_service_uris() -> list[str]:
import yaml # type: ignore[import-untyped]
except ImportError:
raise ImportError(
"the sources extras is not installed. Please install it with `pip install compute-modules[sources]`"
"the sources extras is not installed. Please install it with `pip install foundry-compute-modules[sources]`"
)

with open(os.environ[SERVICE_DISCOVERY_PATH], "r") as f:
Expand All @@ -48,7 +48,7 @@ def get_source(source_api_name: str): # type: ignore[no-untyped-def]
)
except ImportError:
raise ImportError(
"the sources extras is not installed. Please install it with `pip install compute-modules[sources]`"
"the sources extras is not installed. Please install it with `pip install foundry-compute-modules[sources]`"
)

def convert_resolved_source_credentials(
Expand Down