handle failed result post with error post#39
Merged
PaulJKathmann merged 9 commits intodevelopfrom Jul 25, 2025
Merged
Conversation
Generate changelog in
|
lauraAriasFdez
previously approved these changes
Jul 24, 2025
Contributor
lauraAriasFdez
left a comment
lauraAriasFdez
left a comment
There was a problem hiding this comment.
lgtm with minor nits! Lets test it I can show you how to build the sdk locally and download the whl file to test
policy-bot
Bot
dismissed
lauraAriasFdez’s stale review
Invalidated by push of 60b4a7b
| self.logger.error(error) | ||
| except TypeError as e: | ||
| self.logger.error(f"Failed to serialize result to json: {str(e)}") | ||
| self.report_job_result(job_id, json.dumps(self.get_failed_query(e)).encode("utf-8")) |
Contributor
There was a problem hiding this comment.
we should move this to report_job_result_failed with a different error message of failed to deserialize so the failure to post is in the same call
Contributor
Author
There was a problem hiding this comment.
updated accordingly and tested
…e-module into pk/error_handling
Co-authored-by: lauraAriasFdez <52958827+lauraAriasFdez@users.noreply.github.com>
lauraAriasFdez
approved these changes
Jul 25, 2025
|
Released 0.26.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
If posting the job result fails 5 times an exception gets raised but the forwarder doesn't know about it, since it never gets the message from the user code container.
After this PR
Possible downsides?
Are Docs needed?