Merged
Conversation
call schemas before restart endpoint change order in which we call restart and schemas endpoint Add generated changelog entries feature flag the restart notification documentation on how to use feature flag make default True readme -> default True Update pr-40.v2.yml
PaulJKathmann
force-pushed
the
pk/notify_restart
branch
from
8565cd9 to
f3c8d7b
Compare
Contributor
scottkruyswyk
left a comment
scottkruyswyk
left a comment
There was a problem hiding this comment.
A few nits but otherwise looks good!
Co-authored-by: Scott Kruyswyk <skruyswyk@palantir.com>
Co-authored-by: Scott Kruyswyk <skruyswyk@palantir.com>
scottkruyswyk
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
If the user code crashes the forwarder will think the user code is still running until the user code posts a result for the same jobId. However, after restarting the user code will not know about the previously failed job so it will never report on it. This way a node/module might be blocked from receiving new requests after restarting.
After this PR
We inform the forwarder whenever a node starts up so it will remove all existing jobs related to it that it thinks are still running.
Possible downsides?
Are Docs needed?