Document highlighting doesn't work on Windows

[AmjadHD]

This is the result of debugging LSP client for sublime text:

LSP:  --> textDocument/documentHighlight
LSP:      None

using pyls 0.19.0.

[gatesn]

The protocol allows for documentHighlight to return null: https://microsoft.github.io/language-server-protocol/specification#textDocument_documentHighlight

It seems we return null in the case of highlight returning an empty list: https://github.com/palantir/python-language-server/blob/develop/pyls/python_ls.py#L207

[AmjadHD]

@gatesn, actually the problem is windows specific:
The test uris.uri_with(document.uri, path=definition.module_path) == document.uri in

python-language-server/pyls/plugins/highlight.py

Line 16 in 48eedea

return not definition.module_path or uris.uri_with(document.uri, path=definition.module_path) == document.uri

always returns False.
I added some debugging, and it turns out the uris differ in the drive's letter's case:

server: 2019-12-09 21:31:17,826 UTC - ERROR - pyls.plugins.highlight - definition.module_path == c:\Users\User\AppData\Local\Programs\Python\Python38\Lib\site-packages\pyls\plugins\highlight.py
server: 2019-12-09 21:31:17,826 UTC - ERROR - pyls.plugins.highlight - uris.uri_with(document.uri, path=definition.module_path) == file:///c:/Users/User/AppData/Local/Programs/Python/Python38/Lib/site-packages/pyls/plugins/highlight.py
server: 2019-12-09 21:31:17,827 UTC - ERROR - pyls.plugins.highlight - document.uri == file:///C:/Users/User/AppData/Local/Programs/Python/Python38/Lib/site-packages/pyls/plugins/highlight.py

[AmjadHD]

Anyone seeing this ? @ccordoba12 ?

[AmjadHD]

Hellloo, @gatesn, @ccordoba12.

[gatesn]

Apologies, this got lost in my email. I'll look to add a test for the case you mentioned and fix it up

[gatesn]

@AmjadHD could you test the ngates/compare-paths branch?

[AmjadHD]

I'm not sure how to do that:

C:\Users\User>pip install -e git+https://github.com/palantir/python-language-server.git
ERROR: Could not detect requirement name for 'git+https://github.com/palantir/python-language-server.git', please specify one with #egg=your_package_name

[goanpeca]

maybe

pip install git+https://github.com/palantir/python-language-server.git@ngates/compare-paths ?

[AmjadHD]

thanks i already figured it out, @gatesn now it's working.