Completion: Remove pluggy racing and disable Rope by default #212
Conversation
gatesn
left a comment
gatesn
left a comment
There was a problem hiding this comment.
i think we should leave just the single completions hook, and users can enable one, the other, or both.
pyls/hookspecs.py
Outdated
|
|
||
| @hookspec | ||
| def pyls_completions(config, workspace, document, position): | ||
| def pyls_jedi_completions(config, workspace, document, position): |
There was a problem hiding this comment.
Why have two plugin hooks? Why not just control which implementation runs using the configuration?
There was a problem hiding this comment.
I don't think users should be able to use both completion plugins side by side since this will probably result in duplicated completion results and other weird behaviour, or am I missing something.
I can refactor it to only use on completion hook which runs either jedi or rope depending on the config. What do you think?
lgeiger
force-pushed
the
remove-completion-racing
branch
from
76a6db6 to
818a0a8
Compare
|
Apologies for the slow review here, I’m still on vacation until the 9th January. Hope you understand! |
No problem. Happy holidays! |
This allows the user to choose between Rope and Jedi for completions. It also remove the pluggy racing since Jedi's cache isn't thread safe. Closes palantir#189
lgeiger
force-pushed
the
remove-completion-racing
branch
from
818a0a8 to
f86c66e
Compare
|
@lgeiger do you mind if I take over this PR? |
Go ahead! |
2 participants
This allows the user to choose between Rope and Jedi for completions.
It also remove the pluggy racing since Jedi's cache isn't thread safe.
Closes #189