setup.py: exclude all test packages #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatesn
suggested changes
Feb 15, 2019
setup.py
Outdated
| # You can just specify the packages manually here if your project is | ||
| # simple. Or you can use find_packages(). | ||
| packages=find_packages(exclude=['contrib', 'docs', 'test']), | ||
| packages=find_packages(exclude=['contrib', 'docs', 'test*']), |
Contributor
There was a problem hiding this comment.
As mentioned in #495 can we instead use:
Suggested change
| packages=find_packages(exclude=['contrib', 'docs', 'test*']), | |
| packages=find_packages(exclude=['contrib', 'docs', 'test', 'test.*']), |
Whichever change is made first wins :)
There is a subpackage in test. This subpackage was before this commit installed although test package was ignored. Extending exclude to ignore anything that starts with 'test' is enough to exclude any subpackage of test. This is causing an error when trying to package pyls in Gentoo. Gentoo build system disutils eclass checks if there is some test package to be installed and fails installation step if so. This fixes that.
gatesn
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a subpackage in test. This subpackage was before this commit
installed although test package was ignored. Extending exclude to ignore
anything that starts with 'test' is enough to exclude any subpackage of
test.
This is causing an error when trying to package pyls in Gentoo. Gentoo
build system disutils eclass checks if there is some test package to be
installed and fails installation step if so. This fixes that.