-
Notifications
You must be signed in to change notification settings - Fork 286
Add option to activate fuzzy completions in Jedi #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to activate fuzzy completions in Jedi #728
Conversation
|
Thanks for your interest in palantir/python-language-server, @benmezger! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Please don't do that. Instead, please make things work for older Jedi versions as well. |
|
@ccordoba12 I believe using |
…ger/python-language-server into feat/enable-jedi-fuzzy-completion
@ccordoba12 Just out of interest, why do you want to support older versions of Jedi? IMO that's just a waste of resources, since you could force users to install a new one :). |
Because some Jedi versions (e.g. 0.15.0 and 0.15.1) broke completion for scientific Python libraries, and we had to do some ugly workarounds to support older versions that still work with them. I really don't want my comment to sound as a criticism on your work as a maintainer (I'm also a maintainer, so I understand how hard that job is), but I don't want to be hit by that kind of bugs for now. By the way, we're planning to migrate soon to use Jedi 0.16, so this is just a temporary measure. |
While I'm sorry that this happened, in the future you should probably just not upgrade and try to open issues in Jedi. Jedi is probably soon going to be feature complete and 1.0 is coming. |
|
@benmezger, please merge this PR with master and fix the merge conflicts. |
ccordoba12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @benmezger! And thanks for your patience too.
This adds fuzzy support to Jedi as requested by #718. Since fuzzy is only enabled in 0.15.2 (see https://github.com/davidhalter/jedi/blob/master/CHANGELOG.rst#0152-2019-12-20), this PR also update's Jedi's requirements.
Fixes #718