Skip to content

Conversation

@benmezger
Copy link
Contributor

@benmezger benmezger commented Jan 11, 2020

This adds fuzzy support to Jedi as requested by #718. Since fuzzy is only enabled in 0.15.2 (see https://github.com/davidhalter/jedi/blob/master/CHANGELOG.rst#0152-2019-12-20), this PR also update's Jedi's requirements.

Fixes #718

@palantirtech
Copy link
Member

Thanks for your interest in palantir/python-language-server, @benmezger! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@ccordoba12
Copy link
Contributor

this PR also update's Jedi's requirements.

Please don't do that. Instead, please make things work for older Jedi versions as well.

@benmezger
Copy link
Contributor Author

@ccordoba12 I believe using LooseVersion should do the job, but let me know if there is anymore improvements or if I missed anything.

@benmezger benmezger requested a review from ccordoba12 January 27, 2020 21:26
@ccordoba12 ccordoba12 added this to the 0.32.0 milestone Feb 5, 2020
@davidhalter
Copy link

Please don't do that. Instead, please make things work for older Jedi versions as well.

@ccordoba12 Just out of interest, why do you want to support older versions of Jedi? IMO that's just a waste of resources, since you could force users to install a new one :).

@ccordoba12
Copy link
Contributor

Just out of interest, why do you want to support older versions of Jedi?

Because some Jedi versions (e.g. 0.15.0 and 0.15.1) broke completion for scientific Python libraries, and we had to do some ugly workarounds to support older versions that still work with them.

I really don't want my comment to sound as a criticism on your work as a maintainer (I'm also a maintainer, so I understand how hard that job is), but I don't want to be hit by that kind of bugs for now.

By the way, we're planning to migrate soon to use Jedi 0.16, so this is just a temporary measure.

@davidhalter
Copy link

Because some Jedi versions (e.g. 0.15.0 and 0.15.1) broke completion for scientific Python libraries, and we had to do some ugly workarounds to support older versions that still work with them.

While I'm sorry that this happened, in the future you should probably just not upgrade and try to open issues in Jedi. Jedi is probably soon going to be feature complete and 1.0 is coming.

@benmezger benmezger requested a review from ccordoba12 February 11, 2020 18:42
@ccordoba12
Copy link
Contributor

@benmezger, please merge this PR with master and fix the merge conflicts.

@benmezger
Copy link
Contributor Author

@ccordoba12

@ccordoba12 ccordoba12 changed the title Feat: Add fuzzy completion settings to Jedi's engine Add fuzzy completion settings to Jedi's engine May 10, 2020
@ccordoba12 ccordoba12 changed the title Add fuzzy completion settings to Jedi's engine Add option to activate fuzzy completions in Jedi May 10, 2020
Copy link
Contributor

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @benmezger! And thanks for your patience too.

@ccordoba12 ccordoba12 merged commit 3057ac2 into palantir:develop May 10, 2020
@benmezger benmezger deleted the feat/enable-jedi-fuzzy-completion branch May 10, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for fuzzy completions in Jedi

5 participants