Skip to content

Fix issues with parsing except's while computing folding #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2020
Merged

Fix issues with parsing except's while computing folding #740

merged 1 commit into from
Feb 4, 2020

Conversation

@andfoy
Copy link
Contributor

@andfoy andfoy commented Feb 3, 2020 •
edited by ccordoba12
Loading

@ccordoba12 ccordoba12 added this to the 0.31.8 milestone Feb 4, 2020
@ccordoba12 ccordoba12 changed the title PR: Fix issues with except folding parsing PR: Fix issues with parsing except's while computing folding Feb 4, 2020
ccordoba12
ccordoba12 approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andfoy!

@ccordoba12 ccordoba12 merged commit e3368b4 into palantir:develop Feb 4, 2020
@ccordoba12 ccordoba12 changed the title PR: Fix issues with parsing except's while computing folding Fix issues with parsing except's while computing folding Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.31.8

Development

Successfully merging this pull request may close these issues.

Code folding does not fold correctly when there is "except"

2 participants

@andfoy @ccordoba12