Skip to content

Avoid lambda allocation in Tracer.createTrace #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2018
Merged

Avoid lambda allocation in Tracer.createTrace #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tracing/src/main/java/com/palantir/tracing/Tracer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,19 @@ private Tracer() {}
*/
private static Trace createTrace(Optional<Boolean> isObservable, String traceId) {
Preconditions.checkArgument(traceId != null && !traceId.isEmpty(), "traceId must be non-empty: %s", traceId);
boolean observable = isObservable.orElseGet(sampler::sample);
boolean observable = shouldObserve(isObservable);
return new Trace(observable, traceId);
}

// Avoid lambda allocation on hot paths
@SuppressWarnings("OptionalIsPresent")
private static boolean shouldObserve(Optional<Boolean> isObservable) {
if (isObservable.isPresent()) {
return Boolean.TRUE.equals(isObservable.get());
}
return sampler.sample();
}

/**
* Initializes the current thread's trace, erasing any previously accrued open spans. The new trace is {@link
* Trace#isObservable observable} iff the given flag is true, or, iff {@code isObservable} is absent, if the {@link
Expand Down