Test-utils to visualize spans #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferozco
reviewed
Aug 23, 2019
tracing/src/test/java/com/palantir/tracing/HtmlSpanObserver.java
Outdated
Show resolved
Hide resolved
iamdanfox
changed the title
Contributor
Author
|
I've tried this on c-j-r which is a bit weird because many tests don't actually neatly close a trace. I think it gives reasonable output. |
iamdanfox
force-pushed
the
dfox/render-spans
branch
from
94c775c to
508a077
Compare
…into dfox/render-spans
ferozco
force-pushed
the
dfox/render-spans
branch
from
3134b85 to
dd7fba6
Compare
…into dfox/render-spans
iamdanfox
force-pushed
the
dfox/render-spans
branch
from
2fd0737 to
0963fd4
Compare
CRogers
reviewed
Aug 28, 2019
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| final class TestTracingExtension implements BeforeEachCallback, AfterEachCallback { |
Contributor
There was a problem hiding this comment.
why BeforeEachCallback rather than BeforeTestExecution?
Contributor
There was a problem hiding this comment.
It seems like BeforeTestExecution was causing the spans within the setup method to also be captured
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
I sometimes find it hard to intuitively imagine what spans look like, especially when we're talking about async stuff. We also don't have a good way of testing spans in our libraries (e.g. conjure-java-runtime).
After this PR
==COMMIT_MSG==
Tests can now be annotated
@TestTracingto set up snapshot testing.==COMMIT_MSG==
Possible downsides / known limitations
Tracer.setSamplerpart way through the tests (which WC does), they'll get incomplete info in the tests