Skip to content

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Nov 14, 2019

Fixes #349

As per https://github.com/openzipkin/b3-propagation, the trace headers shouldn't contain multiple values.

@gatesn gatesn requested a review from carterkozak November 14, 2019 14:15
@changelog-app
Copy link

changelog-app bot commented Nov 14, 2019

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Replace Trace headers instead of appending them.

Check the box to generate changelog(s)

  • Generate changelog entry

@iamdanfox
Copy link
Contributor

Oof that's kinda trippy, thanks @ngates!

@bulldozer-bot bulldozer-bot bot merged commit 88cf98a into develop Nov 14, 2019
@bulldozer-bot bulldozer-bot bot deleted the ngates/replace-headers branch November 14, 2019 14:44
@svc-autorelease
Copy link
Collaborator

Released 3.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OkHttpTraceInterceptor should replace trace headers, rather than append

4 participants