DeferredTracer avoids an unnecessary deep copy of the current trace #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deep copy is necessary when a DeferredTracer is created, but not just before the current trace is cleared in the body of the deferred action. This does not modify behavior, only reduces unnecessary overhead.
Generate changelog in
|
ferozco
approved these changes
Jan 20, 2021
bulldozer-bot
bot
deleted the
ckozak/DeferredTracer_avoids_unnecessary_deep_copy
branch
Collaborator
|
Released 4.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
The deep copy is necessary when a DeferredTracer is created, but
not just before the current trace is cleared in the body of the
deferred action.
This does not modify behavior, only reduces unnecessary overhead.
After this PR
==COMMIT_MSG==
DeferredTracer avoids an unnecessary deep copy of the current trace
==COMMIT_MSG==