Skip to content

[improvement] CloseableTracer supports all SpanTypes #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2019
Merged

[improvement] CloseableTracer supports all SpanTypes #76

merged 1 commit into from
Feb 18, 2019

Conversation

@diogoholanda
Copy link
Contributor

@diogoholanda diogoholanda commented Feb 14, 2019

Before this PR

CloseableTracer only supported the LOCAL SpanType.

After this PR

CloseableTracer only supports all SpanTypes.

@diogoholanda diogoholanda requested a review from a team as a code owner February 14, 2019 13:45
@bulldozer-bot bulldozer-bot bot merged commit 5cd301b into palantir:develop Feb 18, 2019
@diogoholanda diogoholanda deleted the dholanda/closeable-tracer-support-all-types branch February 18, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dansanduleac dansanduleac dansanduleac approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merge when ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@diogoholanda @dansanduleac