Rust: Add test case for rust/access-after-lifetime-ended #1
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… invalidated reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test case for rust/access-after-lifetime-ended involving an invalid reference. I wanted to understand a bit better what results we're losing with these changes in github#20941 and I think I've accomplished that here - in this case we have a legitimate sink that is neither in unsafe code nor does the sink dereference a pointer (it dereferences a reference converted from a pointer).
This probably isn't too concerning as (1) the unsafe restriction already existed for this query and (2) I suspect this kind of thing isn't a terribly common case.
@paldepind this is why I've been a while figuring out my review for github#20941