Skip to content

fix compatibility with Rails 7#8

Merged
bibendi merged 1 commit intomasterfrom
chore/rails7
May 22, 2022
Merged

fix compatibility with Rails 7#8
bibendi merged 1 commit intomasterfrom
chore/rails7

Conversation

@bibendi
Copy link
Copy Markdown
Collaborator

@bibendi bibendi commented May 22, 2022

Context

Rails 7 added ServerTiming middleware that subscribes to all events so that we need to publish events in a certain format.

rails/rails#36289
activeadmin/activeadmin#7262

Related tickets

Closes #7

What's inside

  • Don't use low-level method publish
  • Minor updates

Checklist:

  • I have added tests

@bibendi bibendi added the bug Something isn't working label May 22, 2022
@bibendi bibendi merged commit 85cc0de into master May 22, 2022
@bibendi bibendi deleted the chore/rails7 branch May 22, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong number of arguments (given 2, expected 5) - Rails 7

1 participant