Skip to content

remvoe onclick from all tags #2715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
samialfattani wants to merge 2 commits into
base: master
Choose a base branch
from
Open

remvoe onclick from all tags #2715

samialfattani wants to merge 2 commits into from

Conversation

@samialfattani
Copy link
Contributor

@samialfattani samialfattani commented Dec 12, 2025

Fixes #2556

@samialfattani
Copy link
Contributor Author

samialfattani commented Dec 12, 2025

it shows this error

    assert rv.status_code == 200
E   assert 404 == 200
E    +  where 404 = <WrapperTestResponse streamed [404 NOT FOUND]>.status_code
________ test_csp[ModalFileAdmin rename dir-modalfa-rename/?path=dir1] _________
flask_admin/tests/csp/test_csp.py:273: in test_csp
    assert rv.status_code == 200
E   assert 404 == 200
E    +  where 404 = <WrapperTestResponse streamed [404 NOT FOUND]>.status_code

whie it is locally passes the test successfullly, !!! any suggestion ?

@ElLorans
Copy link
Contributor

ElLorans commented Dec 22, 2025

I silenced the warning in master, can you pull the latest changes?

@samialfattani samialfattani mentioned this pull request Dec 23, 2025
Open
ElLorans
ElLorans reviewed Dec 24, 2025
View reviewed changes
ElLorans
ElLorans reviewed Dec 24, 2025
View reviewed changes
ElLorans
ElLorans reviewed Dec 24, 2025
View reviewed changes
ElLorans
ElLorans reviewed Dec 24, 2025
View reviewed changes
ElLorans
ElLorans reviewed Dec 24, 2025
View reviewed changes
ElLorans
ElLorans reviewed Dec 24, 2025
View reviewed changes
@samialfattani
Copy link
Contributor Author

samialfattani commented Dec 26, 2025

you can merge now

@samialfattani @ElLorans
remvoe onclick from all tags
e56a0c6 
fix fill_db

wrap all tests  in class

fix dynamic FileAdmin class

fix

add something in the dir1 to avoid empty directory

fix

fix typing

fix

change test structure and renaming

combine both delete-dir and delete-file into one function

Revert changes out of scope from a100538
ElLorans
ElLorans reviewed Jan 4, 2026
View reviewed changes
@ElLorans
Copy link
Contributor

ElLorans commented Jan 4, 2026

I squashed and rebased on top of origin/master to have a cleaner history. If you agree, I/you can remove the , (id= {{ row_id }}) and we can merge if there is no other change in functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ElLorans ElLorans ElLorans left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Convert onclick scripts event listeners

2 participants

@samialfattani @ElLorans