add a test based on busybox to github workflows #3101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhizoome
changed the title
Member
|
Thanks, but I don't want to add this extra complexity. There's a lot of shell/terminal related stuff that's tricky to really test, so I'm happy with comments in those parts for now. It's a good reference if we want to add it later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a test based on busybox to github workflows
In #2944 there has been a discussion whether or not to test the PR. Currently it is proposed to just to add comments so the fix doesn't get reverted by accident. But I got curious and wanted to see how difficult it is to add a busybox based test. Alpinelinux uses busybox by default and there is a convenient github-action to test on alpine.
Of course the maintainers are free to decide, I only want to mention, that if this test becomes a burden, they can always just remove it and we are back on status quo.
NOTE: This will fail till #2944 is merged.