Open
Conversation
bbf4257 to
ffe4a45
Compare
Co-authored-by: Kevin Deldycke <kevin@deldycke.com>
ffe4a45 to
5989375
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP PR to track and study the unmerged changes from @AndreasBackx that were left in the stale
typing/paramtype. See the discussion at #3329 for context.I was able to salvage and rebase on top of
stablethe majority of the initial changes like:ParamTypea generic ABC and introducingParamTypeInfoDictParamTypeInfoDictFuncParamTypeto a genericconvert()return typesCompositeParamTypegeneric with abstractarityStuff that were made obsolete from PRs merged upstream since the last commit in 2024:
BoolParamType: rewritten in Fix reconciliation of envvar withdefault,flag_valueandtypeparameters for flag options #2956Choicenormalization: already part of ExpandChoicetoken normalization + make generic #2796Filedocstring: already cleaned up in Break up arguments section #2586Other stuff that I skipped as too strict:
_compat.pyt.Anytot.AnyStrFilegeneric witht.AnyStr_is_file_likewitht.AnyStrI also extracted from the original
typing/paramtypethe refactor ofconvert_typewhich is not strictly related to typing improvements and live in its own PR for later evaluation at: #3372Related to #2805