Fix HelpFormatter.write_usage with empty args#3402
Open
Im-Siyoun wants to merge 1 commit intopallets:mainfrom
Open
Fix HelpFormatter.write_usage with empty args#3402Im-Siyoun wants to merge 1 commit intopallets:mainfrom
Im-Siyoun wants to merge 1 commit intopallets:mainfrom
Conversation
Author
|
I noticed after opening this PR that #3382 and #3383 previously attempted to address the same issue and were closed. This PR takes a slightly different approach by preserving the existing trailing-space behavior from the usage prefix. In the empty-args case, If this behavior is not desired, or if there is a preferred direction for this issue, I’m happy to adjust the PR or close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3360.
This fixes
HelpFormatter.write_usage()when it is called withoutargs.Previously,
write_usage("Program")passed an empty string towrap_text()while using the usage prefix asinitial_indent. Since there was no text to wrap,wrap_text()returned an empty string and only a blank line was written.This change preserves the usage prefix for the empty-args case, so
write_usage("Program")now writes:"Usage: Program \n"Tests were added to cover this behavior.
Tests run: