Add missing space between option help text and deprecation label

[sjoubert]

Without the space, a deprecated documented option currently appears as:
--deprecated-opt Old option(DEPRECATED[: too old])
After:
--deprecated-opt Old option (DEPRECATED[: too old])

[kdeldycke]

Good catch. The other deprecated messages in Command.get_short_help_str and Command.format_help_text do introduce a space:

• click/src/click/core.py

  Lines 1138 to 1145 in c943271

  	if self.deprecated:
  	localised_deprectated = _("deprecated").upper()
  	deprecated_message = (
  	f"({localised_deprectated}: {self.deprecated})"
  	if isinstance(self.deprecated, str)
  	else f"({localised_deprectated})"
  	)
  	text = f"{_(text)} {deprecated_message}"

• click/src/click/core.py

  Lines 1174 to 1181 in c943271

  	if self.deprecated:
  	localised_deprectated = _("deprecated").upper()
  	deprecated_message = (
  	f"({localised_deprectated}: {self.deprecated})"
  	if isinstance(self.deprecated, str)
  	else f"({localised_deprectated})"
  	)
  	text = f"{_(text)} {deprecated_message}"

So this one is a legitimate inconsistency.

Now looking at that code maybe there is an opportunity for deduplicating code...

[kdeldycke]

So this one is a legitimate inconsistency.

Now looking at that code maybe there is an opportunity for deduplicating code...

I will merge this simple bug fix, and think about the code deduplication later.

[kdeldycke]

Now looking at that code maybe there is an opportunity for deduplicating code...

Good news, there is a real oportunity to deduplicate these messages. I proposed a PR at: #3430