Fix HelpFormatter.write_usage with empty args producing no output#3433
Closed
driphtyio wants to merge 1 commit into
Closed
Fix HelpFormatter.write_usage with empty args producing no output#3433driphtyio wants to merge 1 commit into
driphtyio wants to merge 1 commit into
Conversation
When write_usage is called with no args (the default), wrap_text('')
produces an empty string, so no usage line is printed at all.
Fixed by adding an early return that writes the prefix + prog directly
when args is empty.
Fixes pallets#3360
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3360
Problem
When
write_usageis called with noargs(the default""),wrap_text("")produces an empty string, so no usage line is printed at all.Reproduction
Fix
Added an early return that writes
prefix + progdirectly whenargsis empty or falsy. This avoids passing an empty string towrap_text.